Merge pull request #1041 from fengli79/master

Remove the `attempt` base unit for grpc_client_attempt_started metric
grpc-ecosystem · Jan 28, 2024 · 45d71f9 · 45d71f9
2 parents 9c4f9ee + 73e1903
commit 45d71f9
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 2 deletions.
diff --git a/...toconfigure/src/main/java/net/devh/boot/grpc/client/metrics/MetricsClientInstruments.java b/...toconfigure/src/main/java/net/devh/boot/grpc/client/metrics/MetricsClientInstruments.java
@@ -69,7 +69,6 @@ static MetricsClientMeters newClientMetricsMeters(MeterRegistry registry) {
                 .description(
                         "The total number of RPC attempts started from the client side, including "
                                 + "those that have not completed.")
-                .baseUnit("attempt")
                 .withRegistry(registry));
 
         builder.setSentMessageSizeDistribution(DistributionSummary.builder(

diff --git a/...toconfigure/src/main/java/net/devh/boot/grpc/server/metrics/MetricsServerInstruments.java b/...toconfigure/src/main/java/net/devh/boot/grpc/server/metrics/MetricsServerInstruments.java
@@ -66,7 +66,6 @@ static MetricsServerMeters newServerMetricsMeters(MeterRegistry registry) {
         builder.setServerCallCounter(Counter.builder(SERVER_CALL_STARTED)
                 .description("The total number of RPC attempts started from the server side, including "
                         + "those that have not completed.")
-                .baseUnit("call")
                 .withRegistry(registry));
 
         builder.setSentMessageSizeDistribution(DistributionSummary.builder(