Skip to content

Commit

Permalink
Remove the attempt base unit for grpc_client_attempt_started metric,
Browse files Browse the repository at this point in the history
to make sure the generated metrics name in the Prometheus is actually
grpc_client_attempt_started_total instead of
grpc_client_attempt_started_attempt_total and gets aligned with other
languages (C++ for example).
  • Loading branch information
fengli79 committed Jan 28, 2024
1 parent 9c4f9ee commit 0decfe0
Showing 1 changed file with 0 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ static MetricsClientMeters newClientMetricsMeters(MeterRegistry registry) {
.description(
"The total number of RPC attempts started from the client side, including "
+ "those that have not completed.")
.baseUnit("attempt")
.withRegistry(registry));

builder.setSentMessageSizeDistribution(DistributionSummary.builder(
Expand Down

0 comments on commit 0decfe0

Please sign in to comment.