Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade validator. #465

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

regeda
Copy link

@regeda regeda commented Oct 22, 2021

protoc-gen-validate is release under the v0.6.2:

https://github.com/envoyproxy/protoc-gen-validate/releases/tag/v0.6.2

The release contains the merge PR about "multi-error validation with
ValidateAll()":

bufbuild/protoc-gen-validate#468

protoc-gen-validate is release under the v0.6.2:

https://github.com/envoyproxy/protoc-gen-validate/releases/tag/v0.6.2

The release contains the merge PR about "multi-error validation with
ValidateAll()":

bufbuild/protoc-gen-validate#468
Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not version this anywhere? Someone else could come along and regenerate these files with their own version. We should version the generator somewhere.

@regeda
Copy link
Author

regeda commented Oct 24, 2021

Do we not version this anywhere? Someone else could come along and regenerate these files with their own version. We should version the generator somewhere.

Do you mean this file testing/testproto/test.manual_validator.pb.go?

@johanbrandhorst
Copy link
Collaborator

Sorry, I mean the version of the generator that generates the file. The versions of protoc-gen-validate.

@mweibel
Copy link

mweibel commented Dec 17, 2021

sorry for the noise, but what's the status here? Would be great to have this merged 🎉

@johanbrandhorst
Copy link
Collaborator

We added support for ValidateAll in v2 here: 5b8ad84. If that's what this is about we can close this.

@mweibel
Copy link

mweibel commented Dec 20, 2021

yes, it's about that 👍 I didn't know about v2 yet, is that usable yet?

@johanbrandhorst
Copy link
Collaborator

It should be useable, yeah, but we haven't made stable release version of it yet. There are a few oustanding issues still 😬. https://github.com/grpc-ecosystem/go-grpc-middleware/issues?q=is%3Aissue+is%3Aopen+v2+label%3Av2

@devnev devnev added the v1 label Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants