This repository has been archived by the owner on Jul 26, 2021. It is now read-only.
Editor on .NET Core. #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pavel-Teplitsky
approved these changes
Mar 16, 2020
|
Issues
======
- Added 12
Complexity increasing per file
==============================
- GroupDocs.Editor.MVC/Products/Common/Config/CommonConfiguration.cs 1
- GroupDocs.Editor.MVC/Program.cs 1
- GroupDocs.Editor.MVC/Products/Common/Config/GlobalConfiguration.cs 1
- GroupDocs.Editor.MVC/Products/Common/Config/ApplicationConfiguration.cs 5
- GroupDocs.Editor.MVC/Products/Editor/Config/EditorConfiguration.cs 4
- GroupDocs.Editor.MVC/Products/Common/Entity/Web/FileDescriptionEntity.cs 1
- GroupDocs.Editor.MVC/Products/Common/Util/Parser/YamlParser.cs 2
- GroupDocs.Editor.MVC/Products/Common/Config/ServerConfiguration.cs 1
- GroupDocs.Editor.MVC/Startup.cs 2
- GroupDocs.Editor.MVC/Controllers/EditorController.cs 1
- GroupDocs.Editor.MVC/AppDomainGenerator/DomainGenerator.cs 1
- GroupDocs.Editor.MVC/Products/Editor/Controllers/EditorApiController.cs 19
Clones added
============
- GroupDocs.Editor.MVC/Products/Common/Config/ApplicationConfiguration.cs 1
- GroupDocs.Editor.MVC/Products/Editor/Config/EditorConfiguration.cs 1
See the complete overview on Codacy |
bobkovalex
reviewed
Mar 17, 2020
| } | ||
|
|
||
| // This method gets called by the runtime. Use this method to configure the HTTP request pipeline. | ||
| public void Configure(IApplicationBuilder app, IWebHostEnvironment env) |
There was a problem hiding this comment.
bobkovalex
reviewed
Mar 17, 2020
|
|
||
| namespace GroupDocs.Editor.MVC | ||
| { | ||
| public class Program |
There was a problem hiding this comment.
bobkovalex
reviewed
Mar 17, 2020
| @@ -10,7 +10,8 @@ namespace GroupDocs.Editor.MVC.Products.Common.Util.Parser | |||
| { | |||
| public class YamlParser | |||
| { | |||
| private static string YamlPath = Path.Combine(AppDomain.CurrentDomain.BaseDirectory, "configuration.yml"); | |||
| private static string appRoot = AppContext.BaseDirectory.Substring(0, AppContext.BaseDirectory.LastIndexOf("bin")); | |||
There was a problem hiding this comment.
bobkovalex
reviewed
Mar 17, 2020
| return format; | ||
| } | ||
|
|
||
| private dynamic GetSaveOptions(string saveFilePath) | ||
| private ILoadOptions GetLoadOptions(string guid) |
There was a problem hiding this comment.
bobkovalex
reviewed
Mar 17, 2020
| string license = valuesGetter.GetStringPropertyValue("licensePath"); | ||
| if (String.IsNullOrEmpty(license)) | ||
| string licPath = valuesGetter.GetStringPropertyValue("licensePath"); | ||
| var appRoot = AppContext.BaseDirectory.Substring(0, AppContext.BaseDirectory.LastIndexOf("bin")); |
There was a problem hiding this comment.
bobkovalex
reviewed
Mar 17, 2020
| { | ||
| Mock<IConfigurationSection> mockServerConfSection; | ||
| Mock<IConfigurationSection> mockCommonConfSection; | ||
| Mock<IConfiguration> mockConfig; |
There was a problem hiding this comment.
bobkovalex
reviewed
Mar 17, 2020
| public IConfiguration Configuration { get; } | ||
|
|
||
| // This method gets called by the runtime. Use this method to add services to the container. | ||
| public void ConfigureServices(IServiceCollection services) |
There was a problem hiding this comment.
bobkovalex
reviewed
Mar 17, 2020
| @@ -37,7 +38,9 @@ public EditorConfiguration() | |||
| filesDirectory = valuesGetter.GetStringPropertyValue("filesDirectory", filesDirectory); | |||
| if (!IsFullPath(filesDirectory)) | |||
| { | |||
| filesDirectory = Path.Combine(AppDomain.CurrentDomain.BaseDirectory, filesDirectory); | |||
| // TODO: check for more cross-platform solution | |||
| var appRoot = AppContext.BaseDirectory.Substring(0, AppContext.BaseDirectory.LastIndexOf("bin")); | |||
There was a problem hiding this comment.
bobkovalex
reviewed
Mar 17, 2020
|
|
||
| public class EditorControllerTest | ||
| { | ||
| Mock<IConfigurationSection> mockServerConfSection; |
There was a problem hiding this comment.
bobkovalex
reviewed
Mar 17, 2020
| public class EditorControllerTest | ||
| { | ||
| Mock<IConfigurationSection> mockServerConfSection; | ||
| Mock<IConfigurationSection> mockCommonConfSection; |
There was a problem hiding this comment.
bobkovalex
reviewed
Mar 17, 2020
| return options; | ||
| } | ||
|
|
||
| private ISaveOptions GetSaveOptions(string saveFilePath) |
There was a problem hiding this comment.
bobkovalex
reviewed
Mar 17, 2020
| return options; | ||
| } | ||
|
|
||
| private static List<string> PrepareFormats() | ||
| private IEditOptions GetEditOptions(string guid) |
There was a problem hiding this comment.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please, do not merge this PR yet.
Problem:
We would like to have implementation for the Editor app on .NET Core.
Solution:
Screenshots:
Take a look
How it works on Ubuntu right after re-clone and click RUN in VS Code: