fix: Remove requirement for WebView 2 #9 #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request removes the requirement for WebView 2 in the project's CMake configuration. It modifies the CMakeLists.txt file to remove WebView 2-related settings, potentially simplifying the build process and reducing dependencies. File-Level Changes
Tips
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @greynewell - I've reviewed your changes - here's some feedback:
Overall Comments:
- The change looks clean and straightforward, but could you provide more context on why WebView 2 is being removed and if there are any functional impacts we should be aware of?
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 1 issue found
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| @@ -5,7 +5,6 @@ add_subdirectory(JUCE) | |||
| # Setup JUCE build settings, source code and compile definitions | |||
|
|
|||
| juce_add_plugin(musegpt | |||
| NEEDS_WEBVIEW2 TRUE | |||
| NEEDS_WEB_BROWSER TRUE | |||
There was a problem hiding this comment.
question (documentation): Clarification on web browser usage
With WebView2 removed but NEEDS_WEB_BROWSER still set to TRUE, could you elaborate on what web browser functionality is being used now?
greynewell
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Remove the WebView 2 requirement from the CMake configuration to fix compatibility issues.
Bug Fixes: