Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add powershell script to install WebView2, closes #9 #18

Closed
wants to merge 3 commits into from

Conversation

greynewell
Copy link
Owner

@greynewell greynewell commented Sep 17, 2024

Summary by Sourcery

Fix the Windows release build script by adding a PowerShell command to install the WebView2 dependency, ensuring the plugin has all necessary components.

Bug Fixes:

  • Add a PowerShell script to install the WebView2 dependency for the plugin, addressing a missing dependency issue.

Build:

  • Include a step in the Windows release build script to register a NuGet package source and install the WebView2 package.

Copy link
Contributor

sourcery-ai bot commented Sep 17, 2024

Reviewer's Guide by Sourcery

This pull request adds a PowerShell script to install the WebView2 dependency for the plugin. The changes are implemented in the 'windows_release.ps1' script, which is responsible for setting up the build environment on Windows.

File-Level Changes

Change Details Files
Install WebView2 dependency using NuGet package manager
  • Register NuGet package source
  • Install Microsoft.Web.WebView2 package with specific version
  • Set installation scope to CurrentUser
scripts/build/windows_release.ps1

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @greynewell - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider using a minimum version requirement instead of a specific version for WebView2. This would allow for automatic updates to newer, potentially more secure versions while ensuring compatibility.
  • It might be beneficial to add error handling or checks to ensure the WebView2 installation was successful, and consider providing an option for system-wide installation instead of just for the current user.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟡 Security: 1 issue found
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

scripts/build/windows_release.ps1 Outdated Show resolved Hide resolved
@greynewell
Copy link
Owner Author

This fix didn't work, I instead removed the requirement for WebView 2.

@greynewell greynewell closed this Sep 17, 2024
@greynewell greynewell deleted the fix-windows-build branch September 17, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant