Drop LimitCollectionCreationDeletion from the database
#50
+8,947
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
17 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+1
to
+2
| // <auto-generated /> | ||
| using System; |
There was a problem hiding this comment.
style: Remove BOM character from file
Comment on lines
+1
to
+2
| // <auto-generated /> | ||
| using System; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
🧵 Jira Ticket: PM-10863
📚 Stacked PRs
server: SplitLimitCollectionCreationDeletioninto two database columns bitwarden/server#4709server: SplitOrganization.LimitCollectionCreationDeletioninto two separate business rules bitwarden/server#4730clients: SplitOrganization.LimitCollectionCreationDeletioninto two separate business rules bitwarden/clients#11223server: Turn onLimitCollectionCreationDeletionSplitfor self host bitwarden/server#4808server: RemoveLimitCollectionCreationDeletionSplitfeature flag bitwarden/server#4809clients: RemoveLimitCollectionCreationDeletionSplitfeature flag bitwarden/clients#11258server: DropLimitCollectionCreationDeletionfrom the database bitwarden/server#4810⬆️ YOU ARE HERE
📔 Objective
🤳 The Bigger Picture
There is an option in the Admin Console that removes collection creation and
deletion controls from all organization members that are not in the Owner and
Admin roles. This PR stack splits this conjoined option into two separate
controls: one to block
createoperations and one to blockdeleteoperations. This is a part of an effort to make these settings better align
with what customers expect it to do.
👉 This Pull Request 👍
This is the final pull request in this stack. This commit includes:
LimitCollectionCreationDeletiondatabase column from alldatabase providers.
LimitCollectionCreationDeletionfrom all MSSSQLviews, stored procedures, etc.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changesGreptile Summary
This pull request removes the
LimitCollectionCreationDeletioncolumn from the Organization table across multiple database providers and updates related stored procedures and views.LimitCollectionCreationDeletioncolumn from Organization table in SQL Server, MySQL, PostgreSQL, and SQLiteOrganization_Create,Organization_Update, andOrganization_ReadAbilitiesto remove references to the deprecated columnOrganizationUserOrganizationDetailsViewandProviderUserProviderOrganizationDetailsViewto exclude the removed columnOrganizationentity in Entity Framework Core model to reflect the database changes