Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Draft4 "type" keyword #4

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

laurynasr
Copy link
Contributor

Models with "nullable" were failing to validate against OpenAPI 3.0 schemas because the standard "type" keyword was being used. Aded the Draft4TypeKeyword to SchemaKeywordRegistry in Draft4Support.Enable().

@gregsdennis
Copy link
Owner

Thanks for this. Probably just something I missed.

Could you bump the version in the .csproj file:

<Version>0.2.1</Version>
<FileVersion>0.2.1.0</FileVersion>
<AssemblyVersion>0.2.1.0</AssemblyVersion>

And... it doesn't look like I have release notes 🤦, so I guess that's fine.

(Also, I'd be happy to know how/where you're using the lib!)

@gregsdennis
Copy link
Owner

Pinging @laurynasr

@laurynasr
Copy link
Contributor Author

Sorry for missing the initial reply, I probably need to get my notifications in check.
Pushed a change to bump the versions as asked.

We're using Azure API Management as API gateway, which only supports OpenAPI 3.0 -- so we're using this library in our internal tooling to validate the schemas of our APIs, and samples/requests/responses against those schemas.

@gregsdennis
Copy link
Owner

Glad someone found it useful!

Thanks for the update. I'll merge when the build finishes.

@gregsdennis gregsdennis merged commit 3f8dcb6 into gregsdennis:main Jun 19, 2024
3 checks passed
@laurynasr laurynasr deleted the enable-draft4-type-keyword branch June 19, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants