Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Update Windows script family #786

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Change: Update Windows script family #786

merged 2 commits into from
Jan 23, 2025

Conversation

amy-gb
Copy link
Contributor

@amy-gb amy-gb commented Jan 22, 2025

What

Update the valid OID plugin to use the updated script family for Windows

Why

We realized the NASL files were using the script family from SecPod while the Notus files were using the correct family.

References

https://github.com/greenbone/win-vt-generator/pull/61
vta-642

Checklist

poetry run troubadix -v --include-tests CheckValidOID -d ~/Greenbone/win-vt-generator/temp/nasl
ℹ Start linting 376 files ... 
ℹ Time elapsed: 0:00:00.038954
  Plugin                                             Errors Warnings
  -------------------------------------------------------------------
  -------------------------------------------------------------------
ℹ sum                                                     0        0

@amy-gb amy-gb requested a review from a team as a code owner January 22, 2025 10:27
Copy link

github-actions bot commented Jan 22, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA f343587.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link

github-actions bot commented Jan 22, 2025

Conventional Commits Report

Type Number
Added 1
Changed 1

🚀 Conventional commits found.

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.81%. Comparing base (bd5b6c1) to head (f343587).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #786      +/-   ##
==========================================
- Coverage   79.82%   79.81%   -0.01%     
==========================================
  Files          87       87              
  Lines        3023     3022       -1     
  Branches      589      589              
==========================================
- Hits         2413     2412       -1     
  Misses        462      462              
  Partials      148      148              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amy-gb amy-gb added the make release To trigger GitHub release action label Jan 23, 2025
@pbrozmann
Copy link

Looks good to me, however please also add the script family Windows Local Security Checks to the list VALID_FAMILIES in plugins/script_family.py.

@amy-gb amy-gb merged commit e47fa2d into main Jan 23, 2025
13 checks passed
@amy-gb amy-gb deleted the vta-642 branch January 23, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
make release To trigger GitHub release action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants