Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: update valid_oid plugin for Windows #776

Merged
merged 8 commits into from
Jan 15, 2025
Merged

Add: update valid_oid plugin for Windows #776

merged 8 commits into from
Jan 15, 2025

Conversation

amy-gb
Copy link
Contributor

@amy-gb amy-gb commented Dec 20, 2024

What

Add validation for the generated windows NASL scripts.
Also add missing validation for upcoming OpenSuse generator.

(The other new generators, HCE and openEuler, do not use NASL so Troubadix is irrelevant)

Why

This check is currently failing while testing win-vt-generator.

References

VTA-633

Checklist

  • Tests

@amy-gb amy-gb requested a review from a team as a code owner December 20, 2024 12:07
Copy link

github-actions bot commented Dec 20, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA bd2f8fc.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link

github-actions bot commented Dec 20, 2024

Conventional Commits Report

Type Number
Changed 4

🚀 Conventional commits found.

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.82%. Comparing base (2c78c52) to head (bd2f8fc).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #776      +/-   ##
==========================================
+ Coverage   79.72%   79.82%   +0.09%     
==========================================
  Files          87       87              
  Lines        3009     3023      +14     
  Branches      584      589       +5     
==========================================
+ Hits         2399     2413      +14     
  Misses        462      462              
  Partials      148      148              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amy-gb amy-gb force-pushed the vta-633 branch 2 times, most recently from 3a8c96b to bf4cbff Compare January 8, 2025 12:08
troubadix/plugins/valid_oid.py Outdated Show resolved Hide resolved
@cfi-gb cfi-gb requested a review from a team January 10, 2025 09:41
@amy-gb
Copy link
Contributor Author

amy-gb commented Jan 15, 2025

(venv) ➜  troubadix git:(vta-633) poetry run troubadix -v --include-tests CheckValidOID -d ~/Greenbone/win-vt-generator/temp/nasl
ℹ Start linting 360 files ... 
ℹ Time elapsed: 0:00:00.055111
  Plugin                                             Errors Warnings
  -------------------------------------------------------------------
  -------------------------------------------------------------------
ℹ sum                                                     0        0

@mbrinkhoff mbrinkhoff added the make release To trigger GitHub release action label Jan 15, 2025
@mbrinkhoff mbrinkhoff enabled auto-merge (rebase) January 15, 2025 09:56
@mbrinkhoff mbrinkhoff merged commit a955342 into main Jan 15, 2025
13 checks passed
@mbrinkhoff mbrinkhoff deleted the vta-633 branch January 15, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
make release To trigger GitHub release action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants