-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: plugin for finding excess space before dot in some tags #751
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. OpenSSF Scorecard
Scanned Manifest Files |
Conventional Commits Report
🚀 Conventional commits found. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #751 +/- ##
==========================================
+ Coverage 79.59% 79.79% +0.20%
==========================================
Files 86 87 +1
Lines 2935 2974 +39
Branches 632 639 +7
==========================================
+ Hits 2336 2373 +37
- Misses 453 454 +1
- Partials 146 147 +1 ☔ View full report in Codecov by Sentry. |
453cf3c
to
4725ed0
Compare
d7a70c1
to
9a8f9bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The existing test cases LGTM, thanks a lot for taking care 👍
I would leave the final review, approve and merge for one of the @greenbone/troubadix-maintainers .
Also not sure if it would make sense to split the test_fail
case into single ones for each case but would also leave this up to the @greenbone/troubadix-maintainers
1237ff6
to
207a0a7
Compare
accb72f
to
02ae116
Compare
474f15a
to
768e75c
Compare
0ebb27b
to
03b6dab
Compare
requested changes were done but didn't register here
What
Adds a plugin to check script_tags that use full sentences in their value for excess white spaces before sentence terminating dots.
fix method is implemented to automatically remove the preceding excess white spaces.
21.04 and 22.04 are ignored because they are generated.
Other entries in the ignore list use whitespace in various ways that have excess whitespace before dots, but on purpose, as used for beginning entries in an enumeration.
Why
References
Jira VTOPS-229
Checklist
currently finds 121 occurrences in VT repo,