-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change: Various script_xref() related extensions / modifications. #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conventional Commits Report
🚀 Conventional commits found. |
Codecov Report
@@ Coverage Diff @@
## main #642 +/- ##
=======================================
Coverage 78.19% 78.19%
=======================================
Files 80 80
Lines 2692 2692
Branches 569 569
=======================================
Hits 2105 2105
Misses 441 441
Partials 146 146
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
cfi-gb
force-pushed
the
extend_script_tag_whitespaces
branch
3 times, most recently
from
October 12, 2023 13:56
7ddc3d0
to
814df54
Compare
cfi-gb
changed the title
Change: Extend script_tag_whitespaces to also check script_xref() tags.
Change: Various script_xref() related extensions / modifications.
Oct 13, 2023
mbrinkhoff
approved these changes
Nov 9, 2023
…_get_tag_pattern/TAG_PATTERN
mbrinkhoff
force-pushed
the
extend_script_tag_whitespaces
branch
from
November 9, 2023 09:34
1b1d063
to
5f19897
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Note: #643 should be merged first to have it included in the next release as well
Extending the plugin accordingly to catch something like below seen in greenbone/vulnerability-tests#7373
Old QA step was able to catch this while the new Troubadix not because it seems there was no support for checking
script_xref()
tags within it.While doing this i had also noticed that there were two
_XREF_TAG_PATTERN
defined andget_xref_pattern
didn't worked as expected for thescript_tag_whitespaces.py
plugins so had to do some additional adjustments / updates.Why
Better/extended QA checks and more unit tests.
References
None
Checklist