Change: remove level critical notification option #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conventional Commits Report
🚀 Conventional commits found. |
mgoetzegb
previously approved these changes
Dec 12, 2024
mgoetzegb
reviewed
Dec 12, 2024
There was a problem hiding this comment.
Should we maybe remove the level completely and not just from the option?
In the end I guess it is nowhere enforced what can be set as level string and only the api docs still reference the level critical:
So it could be removed from there as well, as it might be confusing if the docs suggest a level which we can't filter for.
mgoetzegb
approved these changes
Dec 12, 2024
llugin
added a commit
to greenbone/opensight-golang-libraries
that referenced
this pull request
Dec 12, 2024
VTI-425 Remove level critical notification, as it was removed from [notification-service](greenbone/opensight-notification-service#51)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove critical level notification option
Why
It's not used
References
VTI-425