Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: select component render options and search #4302

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

daniele-mng
Copy link
Contributor

@daniele-mng daniele-mng commented Jan 27, 2025

What

  • Fix: Select component list to show deprecated in the labels.
  • Fix: Select component to search on select/deselect

Why

  • When selecting an item for the second time, the dropdown list would show only the selected item

References

GEA-861

Checklist

  • Tests

@daniele-mng daniele-mng requested a review from a team as a code owner January 27, 2025 13:38
Copy link

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA e1e0e52.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link

Conventional Commits Report

Type Number
Bug Fixes 1

🚀 Conventional commits found.

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.70%. Comparing base (6fe8770) to head (e1e0e52).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4302      +/-   ##
==========================================
- Coverage   62.71%   62.70%   -0.01%     
==========================================
  Files        1120     1120              
  Lines       99139    99147       +8     
  Branches     6659     6627      -32     
==========================================
- Hits        62175    62171       -4     
- Misses      36834    36846      +12     
  Partials      130      130              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bjoernricks bjoernricks merged commit 2c802cd into main Jan 28, 2025
18 of 19 checks passed
@bjoernricks bjoernricks deleted the fix-select-component-render-options-and-search branch January 28, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants