-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change: fetch trash resources concurrently #3943
Conversation
Conventional Commits Report
🚀 Conventional commits found. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3943 +/- ##
==========================================
- Coverage 60.05% 59.97% -0.09%
==========================================
Files 1025 1025
Lines 25204 25238 +34
Branches 7468 7468
==========================================
Hits 15136 15136
- Misses 9124 9158 +34
Partials 944 944 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! You may want to resolve the conflicts to include report_configs.
Thanks, resolved. |
What
Run the commands that get trash resources concurrently.
Why
This is faster because it causes gsad to run the GMP requests concurrently.
For example with a trashcan of 1000 alerts, configs and targets:
The time is down to the slowest request (getting the configs).
References
Requires greenbone/gsad/pull/162
Similar PR for configs: /pull/3857