Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: fetch trash resources concurrently #3943

Merged
merged 6 commits into from
Feb 27, 2024

Conversation

mattmundell
Copy link
Contributor

@mattmundell mattmundell commented Jan 4, 2024

What

Run the commands that get trash resources concurrently.

Why

This is faster because it causes gsad to run the GMP requests concurrently.

For example with a trashcan of 1000 alerts, configs and targets:

main: 60s
this PR: 52s

The time is down to the slowest request (getting the configs).

References

Requires greenbone/gsad/pull/162

Similar PR for configs: /pull/3857

Copy link

github-actions bot commented Jan 4, 2024

Conventional Commits Report

Type Number
Changed 2

🚀 Conventional commits found.

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 89 lines in your changes are missing coverage. Please review.

Project coverage is 59.97%. Comparing base (c074336) to head (f358c4c).
Report is 3 commits behind head on main.

❗ Current head f358c4c differs from pull request most recent head 9ce457a. Consider uploading reports for the commit 9ce457a to get more accurate results

Files Patch % Lines
src/gmp/commands/trashcan.js 0.00% 72 Missing and 17 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3943      +/-   ##
==========================================
- Coverage   60.05%   59.97%   -0.09%     
==========================================
  Files        1025     1025              
  Lines       25204    25238      +34     
  Branches     7468     7468              
==========================================
  Hits        15136    15136              
- Misses       9124     9158      +34     
  Partials      944      944              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattmundell mattmundell marked this pull request as ready for review January 8, 2024 14:00
@mattmundell mattmundell requested a review from a team as a code owner January 8, 2024 14:00
Copy link
Contributor

@a-h-abdelsalam a-h-abdelsalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! You may want to resolve the conflicts to include report_configs.

@mattmundell
Copy link
Contributor Author

Looks good! You may want to resolve the conflicts to include report_configs.

Thanks, resolved.

@a-h-abdelsalam a-h-abdelsalam merged commit 13bf58e into greenbone:main Feb 27, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants