Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Add missing apt-get install line to README.md #3900

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Change: Add missing apt-get install line to README.md #3900

merged 2 commits into from
Oct 16, 2023

Conversation

cfi-gb
Copy link
Member

@cfi-gb cfi-gb commented Oct 16, 2023

What

If the nodejs package isn't installed it can't be used later.

Note: https://deb.nodesource.com/ is using different install instructions, we might want to adjust it completely to that:

~$ sudo apt-get update && sudo apt-get install -y ca-certificates curl gnupg
~$ curl -fsSL https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key | sudo gpg --dearmor -o /etc/apt/keyrings/nodesource.gpg
~$ NODE_MAJOR=20
~$ echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_$NODE_MAJOR.x nodistro main" | sudo tee /etc/apt/sources.list.d/nodesource.list
~$ sudo apt-get update && sudo apt-get install nodejs -y

Why

Better documentation

References

None

@cfi-gb cfi-gb requested a review from a team as a code owner October 16, 2023 07:36
@github-actions
Copy link

Conventional Commits Report

Type Number
Changed 1

🚀 Conventional commits found.

README.md Outdated Show resolved Hide resolved
nodesource uses a nodistro codename now and it's not required to use a specific disto codename anmyore. See https://github.com/nodesource/distributions/tree/master#new-update-%EF%B8%8F
@bjoernricks bjoernricks enabled auto-merge (rebase) October 16, 2023 14:06
@bjoernricks bjoernricks merged commit d55bac5 into greenbone:main Oct 16, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants