Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve compose file #534

Merged
merged 8 commits into from
Jan 7, 2025
Merged

Improve compose file #534

merged 8 commits into from
Jan 7, 2025

Conversation

bjoernricks
Copy link
Contributor

What

  • use docker-compose.yml for download instead of versioned file
  • set project already in compose file
  • update supported ubuntu version for compose setup

Why

Get an up to date compose setup easier to handle

Checklist

@bjoernricks bjoernricks requested a review from a team as a code owner January 7, 2025 13:24
@greenbonebot greenbonebot enabled auto-merge (rebase) January 7, 2025 13:24
Copy link

github-actions bot commented Jan 7, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 2e69313.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Every heading should be followed by an empty line for myst markdown.
Update supported Ubuntu version to 24.04 for docker compose guide. Other
versions will likely work too but only support 24.04 from now on.
usable too but
Currently the docker-compose.yml is a symlink to docker-compose-22.4.yml
but this will be changed. We have more or less a rolling release now and
therefore still using 22.4 as the file's version might be misleading and
confusing.
Set the docker compose project in the compose file instead of having to
pass it to all docker compose commands. This is not supported with the
old docker-compose v1.
Always use the lastest and greatest compose file.
@bjoernricks bjoernricks requested a review from y0urself January 7, 2025 14:04
@greenbonebot greenbonebot merged commit c543539 into main Jan 7, 2025
4 checks passed
@greenbonebot greenbonebot deleted the improve-compose branch January 7, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants