streamline team review

[chadwhitacre]

Our team review queue is quite frictive at the moment. Here's what I propose:

• As part of payday, we create a new milestone every week for the week following.
• Applying for a team automatically creates a new GitHub issue (team-review repoinside.gratipay.com repo, Review label~~~~, the latest milestone)
• We revise the content we've been sending in emails, and, rather than sending it in an email, simply put it in the page we display to the user after POSTing to teams/create.json.
• The notification email we send on approve/reject (send email notification for application approvals and rejections #3564) should link back to their review issue.

[chadwhitacre]

https://developer.github.com/v3/issues/#create-an-issue

[chadwhitacre]

We should backfill review_url for existing teams.

[chadwhitacre]

Scrap milestones. You can only have one with the same title at a time. We'll just have it as our policy that a Review ticket must be open at least seven days before it can be decided upon.

[chadwhitacre]

Seems like it would be good to set up a separate GitHub user for this.

[chadwhitacre]

!m @gratipay-gremlin :D

[chadwhitacre]

Actually, let's use a separate repo for team review:

https://github.com/gratipay/review

Advantages:

• Less noise on IG
• Fine-grained control for any community members who want to participate in team review: watch the repo!
• We don't need to give @gratipay-gremlin any special permissions. He can create issues in a public repo with no problem.

[chadwhitacre]

Scratch that. We still need to give him explicit read permission. Still better than write (which is needed for labels).

[chadwhitacre]

Rebased on master.

[chadwhitacre]

Alright, I'm not sure what's up with these remaining failing tests. They fail for me locally, too, but when I run each individually it passes.

[mattbk]

Since this isn't complete yet, does someone need to manually add unreviewed teams from http://gratipay.com/explore/teams to https://github.com/gratipay/review?

Is there a protocol for telling people why they were rejected?

Team review seems important to have in place for #3539.

[chadwhitacre]

[D]oes someone need to manually add unreviewed teams from http://gratipay.com/explore/teams to https://github.com/gratipay/review?

Yes.

Is there a protocol for telling people why they were rejected?

The de facto protocol is to email them. We've rejected five so far (out of 69). Here are the emails we've sent so far:

• review new teams for Gratipay 156 inside.gratipay.com#210 (comment)
• review new teams for Gratipay 158 inside.gratipay.com#234 (comment)
• https://github.com/gratipay/violations/issues/23#issuecomment-111239504 (private; see below)
• review new teams for Gratipay 158 inside.gratipay.com#234 (comment)

The one we haven't emailed yet is gratipay/project-review#8.

Team review seems important to have in place for #3539.

Yes!

[chadwhitacre]

Here's the text of the email sent under https://github.com/gratipay/violations/issues/23#issuecomment-111239504:

Sorry I haven't gotten back to you sooner. We actually decided a few weeks ago that the fansub community as a whole isn't a good fit for Gratipay, for two reasons. First, the way different fansub groups characteristically relate to each other clashes pretty strongly with our brand values, particularly "kindness," and "collaboration." Second, we're not interested in being associated with the legal concerns that surround fansubbing.

You may be interested in https://github.com/liberapay/liberapay.com, an upcoming fork of Gratipay with more relaxed requirements.

[chadwhitacre]

[chadwhitacre]

I think this will fail on master, where we don't use VCR.

[chadwhitacre]

[chadwhitacre]

Backfilling review_url ... I've got URLs for all of the Teams in the team-review repo. Looks like that's 43 of them, leaving 55 from before we settled on that.

[chadwhitacre]

I think I'm gonna merge and deploy, and then backfill.

[chadwhitacre]

Ooh ... but is this gonna break on master since we try to create a GitHub ticket?

[chadwhitacre]

https://travis-ci.org/gratipay/gratipay.com/builds/79222169

[chadwhitacre]

Okay, interesting. The error fallback for GitHub URLs is working! :-)

Not sure what the other error in billing_payday is about tho ...

[chadwhitacre]

Hopefully cleaned up in #3761 ... https://travis-ci.org/gratipay/gratipay.com/builds/79222920.

[chadwhitacre]

Yesssssss.

[chadwhitacre]

The billing_payday error appears to have been spurious.

[chadwhitacre]

Alright, let's get this deployed and fill in the data ...

[chadwhitacre]

Round 1: https://gist.github.com/whit537/597a9b9b4f14c122e6f0.

[chadwhitacre]

Envvars set ...

[chadwhitacre]

Round 2: https://gist.github.com/whit537/7629e5fa5b1f97c33a23.

[chadwhitacre]

Okay! We have review_urls, and a more streamlined application process. :-)