This repository has been archived by the owner on Feb 8, 2018. It is now read-only.
Small fixes in payday.py #2576
Closed
Small fixes in payday.py #2576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 12, 2014 21:53
087 -- 0, 1, 2 performs about 5.7 times faster here. 612 -- better identation. 731 -- typo fixed.
"Comparisons to singletons like None should always be done with 'is' or 'is not', never the equality operators." - PEP 8 See a good reason why (if you don't already know) [here](http://jaredgrubb.blogspot.com.br/2009/04/python-is-none-vs-none.html)
|
Thanks for contributing, but payday is being rewritten (#2508), so the code you're trying to update has in fact been changed already. |
|
@Changaco (et al.) Whenever we get a PR from a first-time contributor, we should try pretty hard to accept the PR, even if it creates more work for us. The reason is that we want new contributors! What a buzzkill to put time and effort into a PR and then to have it rejected. :-( In this case, yes, the code @mafagafo is changing is slated to be gone soon. But looking over these commits, they are really minor, no? I'm not seeing big merge conflicts here w/ the payday rewrite. Who knows? Maybe if we had encouraged @mafagafo by accepting his first PR, he would have helped us review the payday rewrite. ;-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
087 -- 0, 1, 2 performs about 5.7 times faster here.
612 -- better indentation.
731 -- typo fixed.