-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#39 fix toolbar button to navigative to corresponding gratipay page #40
base: master
Are you sure you want to change the base?
Conversation
…o corresponding team/project page, instead of using an inserted button on each website's page.
Before releasing, still need to change version in manifest.json. |
I like the button and limited scope of current extension. A feature to go directly to corresponding Gratipay page is nice to have in addition to it. Also it would be nice to fetch Gratipay status for that project - no account, account without withdrawals, full approved account. |
To make sure are you refering to the inserted button in current version, or the toolbar button I changed in this commit?
@techtonik Thanks for the comment. This commit is addressing this, for the three websites that we support. I intend to implement other features after this. Could you add the other features in #39 please? Some of them are listed there already. |
@techtonik as I see your PR I feel that you prefer the inserted button on each website's page. The reason I want to avoid that is illustrated here. |
Yes. I like inserted button on GitHub. As long as there an easy way to report that something is broken, it is easy to maintain markup for GH. I also don't like that extension now requires access to all user data. I would not install such extension, |
Personally I feel it is more robust to parse url than markup in page.
Current permission list is:
This implementation removed the second, and can easily pair up with the first by filtering url in manifest. Would that sound good to you? |
After the new commit, the permission is the same as before. Please review. |
use the toolbar button (currently link to gratipay.com) to link to corresponding team/project page on gratipay.com, instead of using an inserted button on each website's page.
Original discussion
Tested with bitbucket, twitter, github