drop singledispatch package dependency #233
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop singledispatch package dependency altogether.
Rationale
What the singledispatch import function does is try to fetch it from the builtin functools module first and in case of a failure get it from the singledispatch pakakge. Python added singledispatch in functools in v3.4 and the lowest supported python version for graphene-mongo is v3.8. This means that the singledisptach import is always going to happen from functools and hence the dependency on singledispatch package is simply an overhead, not to mention removing it allows cleaning up a part of code that never gets executed,