Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow read config file #41

Merged
merged 1 commit into from
Aug 10, 2023
Merged

feat: allow read config file #41

merged 1 commit into from
Aug 10, 2023

Conversation

hopeyen
Copy link
Collaborator

@hopeyen hopeyen commented Aug 8, 2023

Description

Allow user to set CONFIG_FILE env var as an alternative way to startup

Issue link (if applicable)

Resolves #31

Checklist

  • Are tests up-to-date with the new changes?
  • Are docs up-to-date with the new changes? (Open PR on docs repo if necessary)

@hopeyen hopeyen added type:feature New or enhanced functionality size:small Small p3 Low priority labels Aug 8, 2023
@hopeyen hopeyen requested a review from pete-eiger August 8, 2023 20:20
@hopeyen hopeyen self-assigned this Aug 8, 2023
@hopeyen hopeyen merged commit 7cdab34 into dev Aug 10, 2023
6 checks passed
@hopeyen hopeyen deleted the hope/config-file-input branch August 10, 2023 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pete-eiger pete-eiger pete-eiger approved these changes

Assignees

@hopeyen hopeyen

Labels
p3 Low priority size:small Small type:feature New or enhanced functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat.Req] Config input file and groupings
2 participants
@hopeyen @pete-eiger