jsonapi_included helper may accept symbol keys #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the `included` helper has a subtle "bug" behavior.
`included("users")` followed by `included(:users)` _already_ works, because the memoization variable accepts both strings and symbol values.
However, invoking the symbol form first will erronously memoize an empty array because the type filtering does not account for symbols.
At the very least, symbol and string usage should be consistent. We could prevent symbol usage entirely by refusing to memoize the symbol-keyed results. However, I think a more friendly resolution is to just allow symbol type comparison to match successfully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
includedhelper has a subtle "bug" behavior.included("users")followed byincluded(:users)already works, because the memoization variable accepts both strings and symbol values. However, invoking the symbol form first will erronously memoize an empty array because the type filtering does not account for symbols.At the very least, symbol and string usage should be consistent. We could prevent symbol usage entirely by refusing to memoize the symbol-keyed results. However, I think a more friendly resolution is to just allow symbol type comparison to match successfully.