Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing events #40

Draft
wants to merge 31 commits into
base: develop
Choose a base branch
from
Draft

Conversation

bomanaps
Copy link

@bomanaps bomanaps commented Sep 8, 2024

Did the basic corrections, pointed out earlier.

Karrenbelt and others added 28 commits September 4, 2024 11:45
@CLAassistant
Copy link

CLAassistant commented Sep 8, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ bomanaps
❌ Karrenbelt
You have signed the CLA already but the status is still pending? Let us recheck it.

@bomanaps bomanaps marked this pull request as draft September 8, 2024 21:29
@sauliusgrigaitis
Copy link
Member

The primary goal of the tracing is to have tracking of execution time of most of the functions in the client. The data should be visible in a convenient way - best would be to have that for each function there would be min time, max time, average and median time. I think it makes sense to implement this only for one module (for example fork_choice) just to get the feel. Please upload the numbers once you have it for running in Holesky for only one initial module. Then we can review the code and confirm that the approach is good.

@bomanaps
Copy link
Author

Thanks for the feedback! I will begin working on implementing the tracing as you suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants