Skip to content

Commit

Permalink
fixup! e2e/disruptors: add port-forwarding scenario to pod and servic…
Browse files Browse the repository at this point in the history
…e tests

Revert Logf -> Errorf change and explain the rationale for Logf
  • Loading branch information
roobre committed Jul 10, 2023
1 parent 82575ab commit a598104
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion e2e/disruptors/pod_e2e_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -154,10 +154,12 @@ func Test_PodDisruptor(t *testing.T) {
}

// apply disruption in a go-routine as it is a blocking function
// TODO: We use Logf to avoid a panic-type error if `tc.injector` returns an error after the test times
// out and `t` is no longer valid, but we should improve this somehow.
go func() {
err := tc.injector(disruptor)
if err != nil {
t.Errorf("failed to setup disruptor: %v", err)
t.Logf("failed to setup disruptor: %v", err)
return
}
}()
Expand Down

0 comments on commit a598104

Please sign in to comment.