-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(otlp): experimental otlp support #2177
base: main
Are you sure you want to change the base?
Conversation
petethepig
commented
Jul 27, 2023
•
edited
Loading
edited
- very much a draft at this point.
- requires a copy of https://github.com/open-telemetry/opentelemetry-proto-profile to be adjacent to the directory
- works with feat(otlp): experimental otlp support pyroscope-go#36 and Adds profiles as another signal petethepig/opentelemetry-collector#1
pkg/api/api.go
Outdated
a.RegisterRoute("/ingest", pyroscopeHandler, true, true, "POST") | ||
a.RegisterRoute("/pyroscope/ingest", pyroscopeHandler, true, true, "POST") | ||
pushv1connect.RegisterPusherServiceHandler(a.server.HTTP, d, a.grpcAuthMiddleware) | ||
a.RegisterRoute("/distributor/ring", d, false, true, "GET", "POST") | ||
a.indexPage.AddLinks(defaultWeight, "Distributor", []IndexPageLink{ | ||
{Desc: "Ring status", Path: "/distributor/ring"}, | ||
}) | ||
|
||
pprofileotlp.RegisterGRPCServer(a.server.GRPC, otlpHandler) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just so you know I don't think we expose GRPC endpoint anywhere in our infra nor in helm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cyriltovena yeah we might need a separate grpc server
go.mod
Outdated
go.opentelemetry.io/collector/pdata v1.0.0-rcv0012 | ||
) | ||
|
||
replace go.opentelemetry.io/collector/pdata => ../opentelemetry-collector/pdata |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be clear, we won't have this dependency once this is ready to merge