Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update _index.md: add information about non-blocking mode to the documentation (backport release-3.2.x) #15959

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

loki-gh-app[bot]
Copy link
Contributor

@loki-gh-app loki-gh-app bot commented Jan 24, 2025

Backport 10fef0c from #15910


What this PR does / why we need it:

I struggled with the issue that after working for more than 10 minutes without an internet connection, all my containers froze and stopped working. I've spent a lot of time fixing this issue and I couldn't even find any mention of such a parameter in the documentation.
Thanks for https://community.grafana.com/t/loki-driver-on-docker-and-getting-stuck-container/56610/2

Which issue(s) this PR fixes:

If the Loki server is unavailable, the running containers run for 10 minutes and freeze. That is, everything that is running inside the container completely stops working, which is unacceptable in my opinion. I was also confused that the documentation doesn't even mention that there is such a log-opt!

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

…e documentation (#15910)

Signed-off-by: Roked <[email protected]>
Co-authored-by: J Stickler <[email protected]>
(cherry picked from commit 10fef0c)
@loki-gh-app loki-gh-app bot added backport size/XS type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories labels Jan 24, 2025
@loki-gh-app loki-gh-app bot requested a review from a team as a code owner January 24, 2025 22:05
@loki-gh-app loki-gh-app bot requested a review from JStickler January 24, 2025 22:05
@JStickler JStickler merged commit d9a8e76 into release-3.2.x Jan 24, 2025
60 of 63 checks passed
@JStickler JStickler deleted the backport-15910-to-release-3.2.x branch January 24, 2025 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport size/XS type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants