-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: fix helm diff in case of forks #15818
Merged
Merged
+11
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment has been minimized.
This comment has been minimized.
fcjack
force-pushed
the
fcjack/fix-helm-diff
branch
from
January 17, 2025 14:36
2cdbef2
to
6a9e76a
Compare
poyzannur
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Helm Diff Output - SummarySingle Binary ScenarioDefault Values ScenarioIngress Values ScenarioLegacy Monitoring ScenarioSimple Scalable AWS Kube IRSA Scenario |
Helm Diff Output - SummarySingle Binary ScenarioDefault Values ScenarioIngress Values ScenarioLegacy Monitoring ScenarioSimple Scalable AWS Kube IRSA Scenario |
svennergr
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The workflow for the helm-diff has the last job as post a comment in the PR with the diffs for each scenario.
When the PR is coming from a fork, we don't have permission to write to the PR in the workflow and the fork CI won't be able to get the right secrets to generate github tokens.
Then we are skipping this job in case of forks, but all the outputs are still accessible via github artifacts in the workflow run.
Special notes for your reviewer:
The change to use the vault secrets was made because is a recommendation from platform team to store the secrets inside vault instead of using the github secrets.
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
deprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR