Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix helm diff in case of forks #15818

Merged
merged 6 commits into from
Jan 21, 2025
Merged

ci: fix helm diff in case of forks #15818

merged 6 commits into from
Jan 21, 2025

Conversation

fcjack
Copy link
Contributor

@fcjack fcjack commented Jan 17, 2025

What this PR does / why we need it:

The workflow for the helm-diff has the last job as post a comment in the PR with the diffs for each scenario.
When the PR is coming from a fork, we don't have permission to write to the PR in the workflow and the fork CI won't be able to get the right secrets to generate github tokens.

Then we are skipping this job in case of forks, but all the outputs are still accessible via github artifacts in the workflow run.

Special notes for your reviewer:

The change to use the vault secrets was made because is a recommendation from platform team to store the secrets inside vault instead of using the github secrets.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@loki-gh-app

This comment was marked as outdated.

@loki-gh-app

This comment was marked as outdated.

@loki-gh-app

This comment has been minimized.

@fcjack fcjack force-pushed the fcjack/fix-helm-diff branch from 2cdbef2 to 6a9e76a Compare January 17, 2025 14:36
@fcjack fcjack marked this pull request as ready for review January 17, 2025 14:44
@fcjack fcjack requested a review from a team as a code owner January 17, 2025 14:44
Copy link
Contributor

@poyzannur poyzannur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fcjack fcjack marked this pull request as draft January 21, 2025 13:49
@fcjack fcjack marked this pull request as ready for review January 21, 2025 13:59
@fcjack fcjack marked this pull request as draft January 21, 2025 14:33
@loki-gh-app
Copy link
Contributor

loki-gh-app bot commented Jan 21, 2025

Helm Diff Output - Summary

Single Binary Scenario
Default Values Scenario
Ingress Values Scenario
Legacy Monitoring Scenario
Simple Scalable AWS Kube IRSA Scenario

@fcjack fcjack marked this pull request as ready for review January 21, 2025 14:43
Copy link
Contributor

Helm Diff Output - Summary

Single Binary Scenario
Default Values Scenario
Ingress Values Scenario
Legacy Monitoring Scenario
Simple Scalable AWS Kube IRSA Scenario

@pull-request-size pull-request-size bot added size/S and removed size/M labels Jan 21, 2025
Copy link
Contributor

@svennergr svennergr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@fcjack fcjack merged commit 0dc9d67 into main Jan 21, 2025
67 checks passed
@fcjack fcjack deleted the fcjack/fix-helm-diff branch January 21, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants