Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(block-scheduler): pin fallback offset during start-up #15642

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

ashwanthgoli
Copy link
Contributor

@ashwanthgoli ashwanthgoli commented Jan 8, 2025

What this PR does / why we need it:

Pin the fallback offset at the time of scheduler creation to ensure planner uses the same fallback offset on subsequent runs.
Without this, the planner could create jobs that are unaligned if the partition has no commits so far and builders are slow finishing the pending work. On a subsequent planning iteration, it could end up using a different fallback timestamp if there are still no commits.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@ashwanthgoli ashwanthgoli marked this pull request as ready for review January 8, 2025 12:20
@ashwanthgoli ashwanthgoli requested a review from a team as a code owner January 8, 2025 12:20
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jan 8, 2025
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Jan 8, 2025
Copy link
Contributor

github-actions bot commented Jan 8, 2025

@ashwanthgoli ashwanthgoli force-pushed the blockscheduler/pin-fallbackoffset branch from 3ebc8a7 to 84a0b0d Compare January 9, 2025 07:52
@pull-request-size pull-request-size bot added size/M and removed size/L labels Jan 9, 2025
Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can handle this more comprehensively later; this is a good stopgap 👍

@owen-d owen-d merged commit 732cc8b into main Jan 9, 2025
59 checks passed
@owen-d owen-d deleted the blockscheduler/pin-fallbackoffset branch January 9, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants