Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added support for overrides exporter #15630

Merged
merged 7 commits into from
Jan 10, 2025
Merged

feat: added support for overrides exporter #15630

merged 7 commits into from
Jan 10, 2025

Conversation

bentonam
Copy link
Contributor

@bentonam bentonam commented Jan 7, 2025 •
edited
Loading

What this PR does / why we need it:

Adds support to the helm chart for the Overrides Exporter

Special notes for your reviewer:

N/A

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Title matches the required conventional commits format, see here

@bentonam bentonam requested a review from a team as a code owner January 7, 2025 16:46
@github-actions github-actions bot added area/helm type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories labels Jan 7, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025 •
edited
Loading

💻 Deploy preview deleted.

poyzannur
poyzannur approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@poyzannur poyzannur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I based my comparison on how jsonnet is configured here and it LGTM.

Thanks for the contribution.

@poyzannur poyzannur merged commit db72164 into main Jan 10, 2025
64 checks passed
@poyzannur poyzannur deleted the helm/overrides-exporter branch January 10, 2025 11:00
@loki-gh-app loki-gh-app bot mentioned this pull request Jan 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyzannur poyzannur poyzannur approved these changes

Assignees
No one assigned
Labels
area/helm size/XL type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bentonam @poyzannur