Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blockbuilder): use index path prefix in objectclient for tsdb creation #15614

Merged

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Jan 6, 2025

Fixes an issue where we wrote indices one "level" up, e.g. we'd write bucket/index_1000/$file.tsdb instead of bucket/index/index_1000/$file.tsdb. This must be consistent across components and this snuck through because different code paths are used for index uploads in the blockbuilder vs index shipper. It's not worth the heavy refactoring to align these considering this is a stopgap while we introduce new format(s) in the builder/scheduler architecture.

@owen-d owen-d requested a review from a team as a code owner January 6, 2025 19:47
Copy link
Contributor

@ashwanthgoli ashwanthgoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ashwanthgoli ashwanthgoli merged commit 55f2dd8 into grafana:main Jan 7, 2025
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants