Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Label filter expression: Change unit suffix suffix to proper case whe… #13344

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jun 27, 2024

Label filter expression: Change unit suffix suffix to proper case when dealing with a Byte datatype

What this PR does / why we need it:
This updates documentation to match functionality described in the source code here.

The lexer does not support lowercase units "kb" or "gb".

Please note I have removed E/PB and E/PiB and will be creating a separate issue for them as they do not seem to be supported at the time.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@ghost ghost self-requested a review as a code owner June 27, 2024 17:44
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Jun 27, 2024
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team] LGTM

@grafanabot
Copy link
Collaborator

This PR must be merged before a backport PR will be created.

1 similar comment
@grafanabot
Copy link
Collaborator

This PR must be merged before a backport PR will be created.

@JStickler JStickler merged commit 91a3486 into main Jun 27, 2024
61 checks passed
@JStickler JStickler deleted the nickgrafana-docs-label-filter-unit-suffix branch June 27, 2024 19:26
grafanabot pushed a commit that referenced this pull request Jun 27, 2024
…se whe… (#13344)

Co-authored-by: J Stickler <[email protected]>
(cherry picked from commit 91a3486)
grafanabot pushed a commit that referenced this pull request Jun 27, 2024
…se whe… (#13344)

Co-authored-by: J Stickler <[email protected]>
(cherry picked from commit 91a3486)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-2.9.x backport release-3.0.x size/S type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants