[Blooms] Consistent hashing via tokens for bloomcompactor #12002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Owen Diehl <[email protected]>
Signed-off-by: Owen Diehl <[email protected]>
Signed-off-by: Owen Diehl <[email protected]>
Signed-off-by: Owen Diehl <[email protected]>
salvacorts
approved these changes
Feb 20, 2024
chaudum
approved these changes
Feb 20, 2024
| return keyspaces, true, nil | ||
| } | ||
|
|
||
| func tokenRangesForInstance(id string, instances []ring.InstanceDesc) (ranges ring.TokenRanges, err error) { |
There was a problem hiding this comment.
Should we eventually move that back into dskit?
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves bloom ring ownership back to a traditional consistent hashing mode via tokens. Copies/adapts some dskit ring code where necessary because
<ReadRing>.GetTokenRangesForInstance()does not currently support non zone-aware topologies.This should also break up the bloom compactor's unit of work by making metas for smaller ranges which are now roughly
(keyspace_range / num_replicas / tokens_per_replica). With the currently hardcoded10tokens per replica, we'll build about 10 times more metas than prior.Also includes a small change to minimize metric construction during chunk iteration where it's not needed, although this may need some more extensive refactoring for more performance benefits later.