-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: area/helm: Modify helm template to use http_listen_port and grpc_listen_port instead of hardcoded value #11646
Changes from 2 commits
c36271d
37f1d91
c598943
65531b2
c540201
3a89bf7
4b2d13d
7c4154a
a381054
b01c17a
7d5fafc
8f6f367
8759798
cf12e4c
d86817f
4bbb6bb
951e574
36d50c9
cb2bbd5
4ab4dc4
af929f1
99c3794
91b26ad
aec0e88
e36fa1c
73b64f1
5757e90
483ceb3
4376ae6
c754aa6
ebbe299
fb81edf
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -14,11 +14,11 @@ spec: | |||||
publishNotReadyAddresses: true | ||||||
ports: | ||||||
- name: http-metrics | ||||||
port: 3100 | ||||||
port: {{ .Values.loki.server.http_listen_port | default 3100 }} | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
No need to set defaults here too, if the user didn't specify the value, helm will use the default from the values.yaml provided by the helm chart, so that resolves to |
||||||
targetPort: http-metrics | ||||||
protocol: TCP | ||||||
- name: grpc | ||||||
port: 9095 | ||||||
port: {{ .Values.loki.server.grpc_listen_port | default 9095 }} | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
targetPort: grpc | ||||||
protocol: TCP | ||||||
selector: | ||||||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -28,11 +28,11 @@ spec: | |||||
clusterIP: None | ||||||
ports: | ||||||
- name: http-metrics | ||||||
port: 3100 | ||||||
port: {{ .Values.loki.server.http_listen_port | default 3100 }} | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
targetPort: http-metrics | ||||||
protocol: TCP | ||||||
- name: grpc | ||||||
port: 9095 | ||||||
port: {{ .Values.loki.server.grpc_listen_port | default 9095 }} | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
targetPort: grpc | ||||||
protocol: TCP | ||||||
selector: | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.