Skip to content

Commit

Permalink
fix: bundle dist and packaging to save duplication
Browse files Browse the repository at this point in the history
  • Loading branch information
trevorwhitney committed Feb 14, 2024
1 parent 6a1d4eb commit 74c6c80
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 123 deletions.
4 changes: 2 additions & 2 deletions .github/jsonnetfile.lock.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
"subdir": ""
}
},
"version": "e87bbbd61b9b64782371492000c5ce130d172ffe",
"sum": "N9EocUYpQ3HT6ZysJxmLt3SI2fi/rZMOgMxnbh9qkDg="
"version": "f2ecd4b9e440db32204d56ea3fa464528791dfb7",
"sum": "kwWkJCH7fQrx+taP3aG6DbSSogKZJUOJH+zg90LKJk4="
}
],
"legacyImports": false
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions .github/vendor/github.com/grafana/loki-release/main.jsonnet

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

34 changes: 2 additions & 32 deletions .github/workflows/minor-release-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ jobs:
create-release-pr:
needs:
- "dist"
- "packages"
- "fluent-bit"
- "fluentd"
- "logcli"
Expand Down Expand Up @@ -157,10 +156,11 @@ jobs:
credentials_json: "${{ secrets.GCS_SERVICE_ACCOUNT_KEY }}"
- env:
BUILD_IN_CONTAINER: false
DRONE_TAG: "${{ needs.version.outputs.version }}"
IMAGE_TAG: "${{ needs.version.outputs.version }}"
SKIP_ARM: true
name: "build artifacts"
run: "make dist"
run: "make dist packages"
shell: "bash"
working-directory: "release"
- name: "upload build artifacts"
Expand Down Expand Up @@ -692,36 +692,6 @@ jobs:
matrix:
platform:
- "linux/amd64"
packages:
container:
image: "grafana/loki-build-image:0.33.0"
needs:
- "version"
runs-on: "ubuntu-latest"
steps:
- name: "pull code to release"
uses: "actions/checkout@v4"
with:
path: "release"
repository: "${{ env.RELEASE_REPO }}"
- name: "auth gcs"
uses: "google-github-actions/auth@v2"
with:
credentials_json: "${{ secrets.GCS_SERVICE_ACCOUNT_KEY }}"
- env:
BUILD_IN_CONTAINER: false
DRONE_TAG: "${{ needs.version.outputs.version }}"
name: "package"
run: "make packages"
shell: "bash"
working-directory: "release"
- name: "upload packages"
uses: "google-github-actions/upload-cloud-storage@v2"
with:
destination: "loki-build-artifacts/${{ github.sha }}/packages"
parent: false
path: "release/dist"
process_gcloudignore: false
promtail:
needs:
- "version"
Expand Down
34 changes: 2 additions & 32 deletions .github/workflows/patch-release-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ jobs:
create-release-pr:
needs:
- "dist"
- "packages"
- "fluent-bit"
- "fluentd"
- "logcli"
Expand Down Expand Up @@ -157,10 +156,11 @@ jobs:
credentials_json: "${{ secrets.GCS_SERVICE_ACCOUNT_KEY }}"
- env:
BUILD_IN_CONTAINER: false
DRONE_TAG: "${{ needs.version.outputs.version }}"
IMAGE_TAG: "${{ needs.version.outputs.version }}"
SKIP_ARM: false
name: "build artifacts"
run: "make dist"
run: "make dist packages"
shell: "bash"
working-directory: "release"
- name: "upload build artifacts"
Expand Down Expand Up @@ -692,36 +692,6 @@ jobs:
matrix:
platform:
- "linux/amd64"
packages:
container:
image: "grafana/loki-build-image:0.33.0"
needs:
- "version"
runs-on: "ubuntu-latest"
steps:
- name: "pull code to release"
uses: "actions/checkout@v4"
with:
path: "release"
repository: "${{ env.RELEASE_REPO }}"
- name: "auth gcs"
uses: "google-github-actions/auth@v2"
with:
credentials_json: "${{ secrets.GCS_SERVICE_ACCOUNT_KEY }}"
- env:
BUILD_IN_CONTAINER: false
DRONE_TAG: "${{ needs.version.outputs.version }}"
name: "package"
run: "make packages"
shell: "bash"
working-directory: "release"
- name: "upload packages"
uses: "google-github-actions/upload-cloud-storage@v2"
with:
destination: "loki-build-artifacts/${{ github.sha }}/packages"
parent: false
path: "release/dist"
process_gcloudignore: false
promtail:
needs:
- "version"
Expand Down

0 comments on commit 74c6c80

Please sign in to comment.