check

fix: ConnectionString for Azure Blob storage now supports SAS connstr… #4205

Sign in to view logs

Triggered via pull request June 28, 2024 07:37

roelarents

opened #13348

roelarents:fix-azure-connection-string-sas-endpoint

Status Failure

Total duration 5m 39s

Artifacts –

check.yml

on: pull_request

check / checkFiles

check / faillint

check / golangciLint

check / integration

check / lintFiles

check / testLambdaPromtail

check / testPushPackage

check / collectPackages

Matrix: check / testPackages

check / failCheck

Annotations

5 errors and 2 warnings

check / testPackages (pkg/storage)

Process completed with exit code 1.

check / testPackages (clients/pkg)

The job was canceled because "pkg_storage" failed.

check / testPackages (clients/pkg)

The operation was canceled.

check / golangciLint

issues found

check / failCheck

Process completed with exit code 2.

check / golangciLint

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: golangci/golangci-lint-action@08e2f20817b15149a52b5b3ebe7de50aff2ba8c5. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

check / golangciLint: pkg/storage/chunk/client/azure/blob_storage_client.go#L678

indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)