Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: embed k6 binary #49

Merged
merged 1 commit into from
Jul 23, 2024
Merged

feat: embed k6 binary #49

merged 1 commit into from
Jul 23, 2024

Conversation

Llandy3d
Copy link
Member

Closes https://github.com/grafana/k6-cloud/issues/2496
The files start to be big but still manageable, we might have to consider for the future to run the local k6 in development and bundle k6 only when building the final binary.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we download the binary as a part the build&publish process instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I think so.

Should we keep using the local k6 for development 🤔

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably! Although I don't yet understand the implications of either choice

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bundling everything would have made it work out of the box.

Bundling only on release means that locally we need an alternative when developing, running the local k6 version is a good option with the only caveat is possibly running a different k6 version than the one you are going to bundle.

I can take more time to look into it 🙇

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we download the binary on npm start if it doesn't exist in the folder?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smart

@going-confetti going-confetti self-requested a review July 23, 2024 10:54
Copy link
Collaborator

@going-confetti going-confetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We should get rid of the binaries by the time we're ready for public preview IMO

@Llandy3d Llandy3d merged commit 6241397 into main Jul 23, 2024
1 check passed
@Llandy3d Llandy3d deleted the embed_k6 branch July 23, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants