fix: Remove base64 conversion #46
Conversation
Some mime types should be left as base64
| @@ -38,7 +38,8 @@ function parseRequest(request: Entry['request']): Request { | |||
| } | |||
|
|
|||
| function parseResponse(response: Entry['response']): Response { | |||
| const content = response.content?.text ? atob(response.content.text) : '' | |||
| const content = response.content?.text ?? '' | |||
There was a problem hiding this comment.
@Llandy3d this seems to be similar to one of the ideas you shared, do we also need to change something on the proxy side for this to work?
There was a problem hiding this comment.
I don't think we can so we should consider the alternative, I will leave another comment
There was a problem hiding this comment.
so we will have to leave this because we base64 encode data from the proxy to be able to send it as json (including binary data).
So I don't think it's feasible for us to not expect the base64 encoded content.
proxyData in both Recorder & Validator is straight out of the proxy so it is indeed base64 encoded.
proxyData in the Generator is decoded to be able to work with it, so this is the only broken scenario as far as I'm understanding.
Here we have some options:
- we can detect if a renderable content is base64 encoded and if not, re-encode it
- we could decode only the mime-types that we are actually going to work on
I think the first one might be a good approach since the issue is appearing only in rendering, I assume there could be more edge cases we are not considering 🤔
|
Closing in favour of #46 |
Why
Removing general base64 conversion to be consistent across the application.
How to test
Response preview should now work on the Generation and Validation view
Notes
Alternatively we keep this and re-base64 media content