fix: failed to establish a connection with the upstream server #263
Conversation
cristianoventura
requested review from
going-confetti and
Llandy3d
and removed request for
a team
| onSelectFile: () => void | ||
| } | ||
|
|
||
| export const FileUploadInput = ({ |
There was a problem hiding this comment.
I extracted this file into its own component so it can be reused for the recorder's Browser Path as well
|
I think I encountered a bug, after following the happy path by checking the settings again it was presented as 
|
| @@ -72,9 +68,7 @@ export const SettingsDialog = ({ open, onOpenChange }: SettingsDialogProps) => { | |||
|
|
|||
| <Flex gap="3" justify="end"> | |||
| <Dialog.Close> | |||
| <Button variant="outline" onClick={handleCancelClick}> | |||
There was a problem hiding this comment.
I think I encountered a bug, after following the happy path by checking the settings again it was presented as
regularwhile the file on disk did indeed still include the correct proxy config. (A restart fixed it but we might want to look into it)
@Llandy3d there was a leftover logic from when Settings was still a page and the form state needed to be reset. This should fix the issue.
Description
This PR adds a new field in settings to allow users to input the certificate file (
pem,p12orcer) so a trusted connection can be established with the upstream server if it requires SSL.How to Test
In your local dev environment, there is a directory in
resources/certificates. This directory will be used to initialize a new instance of mitmproxy for testing purposes.Launch a new instance of mitmproxy with SSL configured, pointing the certificate folder to your local environment.
Happy path:
upstreamand point to the other instance of mitmproxymitmproxy-ca-cert.pem(for macOS) ormitmproxy-ca-cert.p12(for Windows) from the certificates folderSad path:
Checklist
npm run lint) and all checks pass.npm test) and all tests pass.Screenshots (if appropriate):
Related PR(s)/Issue(s)
Resolves #260