Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Use NoRequestsMessage explicitly #262

Merged
merged 1 commit into from
Oct 21, 2024
Merged

refactor: Use NoRequestsMessage explicitly #262

merged 1 commit into from
Oct 21, 2024

Conversation

going-confetti
Copy link
Collaborator

@going-confetti going-confetti commented Oct 21, 2024 •
edited
Loading

Description

This is a rather small change that is needed for #261, because Recorder won't have the Grot illustration anymore

How to Test

  • Verify that the empty state looks as expected in the following places
    • Recorder
    • Recording previewer (create an empty recording, by starting a recording and clearing the requests before clicking stop)
    • Validator
    • Validator dialog in Generator

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (npm run lint) and all checks pass.
  • I have run tests locally (npm test) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Screenshots (if appropriate):

Related PR(s)/Issue(s)

@going-confetti going-confetti marked this pull request as ready for review October 21, 2024 10:43
@going-confetti going-confetti requested a review from a team as a code owner October 21, 2024 10:43
@going-confetti going-confetti requested review from cristianoventura and Llandy3d and removed request for a team October 21, 2024 10:43
@going-confetti going-confetti merged commit 418310d into main Oct 21, 2024
2 checks passed
@going-confetti going-confetti deleted the refactor/no-requests-message branch October 21, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Llandy3d Llandy3d Llandy3d approved these changes

@cristianoventura cristianoventura Awaiting requested review from cristianoventura cristianoventura is a code owner automatically assigned from grafana/k6-studio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@going-confetti @Llandy3d