-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Generator drawer #16
Conversation
going-confetti
commented
Jun 27, 2024
•
edited
Loading
edited
src/codegen/codegen.ts
Outdated
variables: Record<string, string> | ||
): string { | ||
return Object.entries(variables) | ||
.map(([key, value]) => `const ${key} = ${value}`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe should be const ${key} = "${value}"
since we're converting everything to strings :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yap, I would encase it in quotes
src/codegen/codegen.ts
Outdated
variables: Record<string, string> | ||
): string { | ||
return Object.entries(variables) | ||
.map(([key, value]) => `const ${key} = ${value}`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yap, I would encase it in quotes