Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tempo-distributed] Added support for OTLP gRPC ingest on gateway. #3261

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dipu018
Copy link

@dipu018 dipu018 commented Aug 5, 2024

Background: The gateway deployed by tempo-distributed helm chart did not support ingest over gRPC for OTLP.
Changes:

  • added additionalPorts to gateway deployment so that port 4317 can be exposed if needed.
  • added gRPC on 4317 in nginx config to route to distributor endpoint.

Use:

gateway:
  additionalPorts: 
    - name: grpc-otlp
      port: 4317
      protocol: TCP
  service:
    additionalPorts: 
      - name: grpc-otlp
        port: 4317
        targetPort: 4317
        protocol: TCP

Tested with Telemetrygen v0.104.0.

Signed-off-by: Dipankar Bagchi <[email protected]>
@dipu018
Copy link
Author

dipu018 commented Aug 5, 2024

Fixes issues #1389 and #733

Copy link
Collaborator

@Sheikh-Abubaker Sheikh-Abubaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please address the failed CI lint tests, Thank you!

@tshuma1
Copy link

tshuma1 commented Sep 17, 2024

will this be merged anytime soon ?

@Sheikh-Abubaker
Copy link
Collaborator

will this be merged anytime soon ?

All the checks and conflicts must be resolved before merging.

@tshuma1
Copy link

tshuma1 commented Sep 17, 2024

will this be merged anytime soon ?

All the checks and conflicts must be resolved before merging.

guess i'll fork this and fix

@Sheikh-Abubaker
Copy link
Collaborator

guess i'll fork this and fix

I'd suggest let @dipu018 try first and then we'll see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants