Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[grafana] Set the root url to match the ingress value used #3243

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[grafana] Set the root url to match the ingress value used #3243

wants to merge 2 commits into from

Conversation

dajose
Copy link

@dajose dajose commented Jul 25, 2024

Fix for #676

@CLAassistant
Copy link

CLAassistant commented Jul 25, 2024 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ zanhsieh
❌ dajose
You have signed the CLA already but the status is still pending? Let us recheck it.

@zanhsieh zanhsieh changed the title Set the root url to match the ingress value used [grafana] Set the root url to match the ingress value used Jul 31, 2024
Sheikh-Abubaker
Sheikh-Abubaker reviewed Aug 15, 2024
View reviewed changes
Copy link
Collaborator

@Sheikh-Abubaker Sheikh-Abubaker left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please address the ci errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sheikh-Abubaker Sheikh-Abubaker Sheikh-Abubaker left review comments

@jkroepke jkroepke Awaiting requested review from jkroepke jkroepke is a code owner

@maorfr maorfr Awaiting requested review from maorfr maorfr is a code owner

@torstenwalter torstenwalter Awaiting requested review from torstenwalter torstenwalter is a code owner

@Xtigyro Xtigyro Awaiting requested review from Xtigyro Xtigyro is a code owner

@zanhsieh zanhsieh Awaiting requested review from zanhsieh zanhsieh is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dajose @CLAassistant @Sheikh-Abubaker @zanhsieh