Remove mergeDashboard flows from SceneViewer, remove LayoutPanel #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idastambuk
requested review from
hwandersman,
a team,
iwysiu and
nmarrs
and removed request for
a team
hwandersman
reviewed
Oct 11, 2024
src/panels/layout/LayoutPanel.tsx
Outdated
| @@ -16,7 +16,7 @@ import { | |||
| } from 'common/manager'; | |||
| import { ReplaySubject, of, throwError } from 'rxjs'; | |||
| import { getCurrentDashboard } from 'common/dashboard'; | |||
| import { doQueryUpdate, mergeDashboard } from './merge'; | |||
| import { doQueryUpdate } from './merge'; | |||
| import { TWINMAKER_PANEL_TYPE_ID } from 'common/constants'; | |||
|
|
|||
| const twinMakerQueries: Array<Partial<TwinMakerQuery>> = [ | |||
There was a problem hiding this comment.
Do we want to fully remove the LayoutPanel from the app plugin? It hasn't served us any purpose in 3 years
hwandersman
approved these changes
Oct 11, 2024
idastambuk
changed the title
hwandersman
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We're not using this feature at this moment, so removing it since it doesn't have support/equivalent in the new Grafana dashboard architecture.
More info here and here
Testing: The scene viewer alarm selection in the Alarm dashboard should work the same as before (with the enabled
dashboardScenefeature toggle)Special notes for your reviewer: