Add error source #951
Merged
Add error source #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aangelisc
requested review from
bossinc,
adamyeats,
katebrenner and
alyssabull
|
Use the following command to run this PR with Docker at http://localhost:3000: |
adamyeats
approved these changes
Aug 20, 2024
SpencerTorres
approved these changes
Aug 20, 2024
|
I wonder if this solves or improves #187 |
bossinc
approved these changes
Aug 27, 2024
|
Hey @SpencerTorres, thanks for the review. For now I don't think it'll fix that issue but we can look into that soon 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add errorsource to any errors that are downstream and may be returned at some point in the QueryData endpoint. A downstream error is anything that is not due to the plugin directly.
The majority of this is handled by
sqldsdirectly but I've tried to account for any cases where it isn't handled.