-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cloudwatch exporter dependency #6835
Open
andriikushch
wants to merge
59
commits into
main
Choose a base branch
from
kgeckhart/update-cloudwatch-exporter-dependency
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update cloudwatch exporter dependency #6835
andriikushch
wants to merge
59
commits into
main
from
kgeckhart/update-cloudwatch-exporter-dependency
+730
−697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # go.mod # go.sum # internal/component/prometheus/exporter/cloudwatch/config.go
# Conflicts: # go.mod
# Conflicts: # go.mod # go.sum
rfratto
added
variant/static
Related to Grafana Agent Static.
variant/flow
Relatd to Grafana Agent Flow.
outdated-dependency
Depdency of the project that is out of date
labels
Apr 9, 2024
# Conflicts: # go.mod # go.sum
…ter-dependency # Conflicts: # internal/component/prometheus/exporter/cloudwatch/config.go
docs/sources/flow/reference/components/prometheus.exporter.cloudwatch.md
Outdated
Show resolved
Hide resolved
…udwatch.md Co-authored-by: Clayton Cornell <[email protected]>
…ter-dependency # Conflicts: # CHANGELOG.md # go.mod # go.sum # internal/build/build.go
clayton-cornell
added
the
type/docs
Docs Squad label across all Grafana Labs repos
label
May 16, 2024
4 tasks
Doc changes look OK to me. Over to the @grafana/grafana-agent-maintainers for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
outdated-dependency
Depdency of the project that is out of date
type/docs
Docs Squad label across all Grafana Labs repos
variant/flow
Relatd to Grafana Agent Flow.
variant/static
Related to Grafana Agent Static.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR adds a new configuration parameter for the Cloudwatch exporter. It allows the specification of the AWS SDK version to be used.
v1
is the default version.It was achieved by updating and integrating the version of the
github.com/nerdswords/yet-another-cloudwatch-exporter
package and all dependencies that it depends on.According to the https://github.com/nerdswords/yet-another-cloudwatch-exporter/blob/a275f94e5d33b3b5330ecfced86c290e1db05928/pkg/config/feature_flags.go#L10 , using the AWS SDK v2, should improve performance.
Breaking change
After this change, using aliases for the AWS service names is no longer allowed.
Which issue(s) this PR fixes
N.A.
A related change in the Alloy project:
Notes to the Reviewer
There is a breaking change in the PR.
PR Checklist