Add graceful shutdown to loki.write draining the WAL
#5804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
clayton-cornell
added
the
type/docs
thepalbi
force-pushed
the
pablo/loki-write-drain-on-stop
branch
from
3514f0f
to
6c33067
Compare
mattdurham
reviewed
Nov 22, 2023
mattdurham
reviewed
Nov 22, 2023
mattdurham
reviewed
Nov 22, 2023
| @@ -90,19 +91,22 @@ func TestUnmarshallWalAttrributes(t *testing.T) { | |||
| MaxSegmentAge: wal.DefaultMaxSegmentAge, | |||
| MinReadFrequency: wal.DefaultWatchConfig.MinReadFrequency, | |||
| MaxReadFrequency: wal.DefaultWatchConfig.MaxReadFrequency, | |||
| DrainTimeout: wal.DefaultWatchConfig.DrainTimeout, | |||
There was a problem hiding this comment.
Can we have one more config , For Ex: MaxSegmentSize which will deletes the logs when it touches the disk space size. which will be useful in some situations where the following error throws
msg=failed to write entry component=loki.write.remote err=write /tmp/agent/loki.write.remote/wal/00000569: no space left on device.
There was a problem hiding this comment.
In my opinion, the device that backs the WAL running out of space is a smell that something is happening, between:
- the agent scraping more that it can send
- the WAL volume is too small
- one should be able to make the WAL delete all segments more rapidly with
max_segment_age, which makes sense since the WAL needs to be thought more of keeping the last X minutes of data rather than X bytes of data
Can you share a bit more of your use case, to understand why the WAL volume is reaching it's capacity?
thepalbi
force-pushed
the
pablo/loki-write-drain-on-stop
branch
from
f6ea92c
to
5cde5fc
Compare
|
@mattdurham all comments should be resolved |
BarunKGP
pushed a commit
to BarunKGP/grafana-agent
that referenced
this pull request
Feb 20, 2024
* drain test and routing * refactoring watcher to use state * drain working * fine-tuned test case * added short timeout test * prompt exit test * prompt exit passing * refactoring watcher * some comments * map river configs * add docs * splitting apart Stop and Drain * minimize manager stop time
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR is a follow up after some discussions in #5770.
The idea of this PR is to allow
loki.writeto do a graceful shutdown when the component is stopped. This graceful shutdown will attempt to drain the WAL, making the watcher consume all of the segments it can, before a timeout occurs. Note that two timeouts will managet the WAL enabledloki.writecomponent: the WAL drain timeout, and the queue client drain timeout.Also, the Watcher is refactored a bit to simlify the "possible states" in which this operates.
Which issue(s) this PR fixes
Related to https://github.com/grafana/cloud-onboarding/issues/5407
Notes to the Reviewer
PR Checklist