Remove windows fork #5784
Merged
Remove windows fork #5784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdurham
requested review from
erikbaranowski
and removed request for
erikbaranowski
rfratto
reviewed
Nov 15, 2023
rfratto
approved these changes
Nov 16, 2023
tpaschalis
approved these changes
Nov 16, 2023
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This removes the reference to the windows_fork. Special shoutout to @jkroepke for work on allowing the windows_exporter to use configuration.
The only real painful point is I had to pin
replace golang.org/x/exp => golang.org/x/exp v0.0.0-20230713183714-613f0c0eb8a1since the sortfunc changed definition in the newest version and loki doesnt handle that.Which issue(s) this PR fixes
Closes ##3420
Notes to the Reviewer
PR Checklist