helm chart: align k8s version label with Values #5773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpaschalis
reviewed
Nov 15, 2023
| @@ -2,7 +2,7 @@ apiVersion: v2 | |||
| name: grafana-agent | |||
| description: 'Grafana Agent' | |||
| type: application | |||
| version: 0.27.2 | |||
There was a problem hiding this comment.
Bumping this will automatically publish a new chart version. IMHO it's not required straight away, let's leave it as-is.
Otherwise, we'll have to update the CHANGELOG headers to mirror that.
tpaschalis
reviewed
Nov 15, 2023
tpaschalis
approved these changes
Nov 15, 2023
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Use helm chart template functions to supply
app.kubernetes.io/versionwith value as configured by any possible override for the Agent image tag version to the Helm chart Values.PR Checklist