flow: Add otelcol.receiver.vcenter component #5715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptodev
reviewed
Nov 10, 2023
docs/sources/flow/reference/components/otelcol.receiver.vcenter.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.receiver.vcenter.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.receiver.vcenter.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.receiver.vcenter.md
Outdated
Show resolved
Hide resolved
| require.NoError(t, ctrl.WaitRunning(time.Second)) | ||
| } | ||
|
|
||
| func TestArguments_UnmarshalRiver(t *testing.T) { |
There was a problem hiding this comment.
For unmarshal tests, I personally prefer the table driven approach. It allows you to add lots of tests with minimal overhead.
For example, I'd use the map[string]interface{} style when some config structs are internal to OTel:
https://github.com/grafana/agent/blob/main/component/otelcol/processor/span/span_test.go
If none of the config structs are internal, I'd go for specifying the OTel structs directly:
https://github.com/grafana/agent/blob/main/component/otelcol/connector/servicegraph/servicegraph_test.go
docs/sources/flow/reference/components/otelcol.receiver.vcenter.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.receiver.vcenter.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.receiver.vcenter.md
Outdated
Show resolved
Hide resolved
…r.md Co-authored-by: Paulin Todev <[email protected]>
…r.md Co-authored-by: Paulin Todev <[email protected]>
…r.md Co-authored-by: Paulin Todev <[email protected]>
…r.md Co-authored-by: Paulin Todev <[email protected]>
Co-authored-by: Paulin Todev <[email protected]>
…r.md Co-authored-by: Paulin Todev <[email protected]>
ptodev
reviewed
Nov 15, 2023
docs/sources/flow/reference/components/otelcol.receiver.vcenter.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.receiver.vcenter.md
Outdated
Show resolved
Hide resolved
ptodev
reviewed
Nov 16, 2023
ptodev
reviewed
Nov 16, 2023
ptodev
reviewed
Nov 16, 2023
docs/sources/flow/reference/components/otelcol.receiver.vcenter.md
Outdated
Show resolved
Hide resolved
ptodev
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
Thanks you, I'm happy for the PR to be merged. I do think we need to address the currently open comments on a follow-up PR though.
Also, we need more tests in the follow-up PR:
- tests for unmarshaling config
- a test which starts a mock http server and sends a mock payload, so that we can test that all metrics and attributes are streamed ok
ptodev
reviewed
Nov 16, 2023
Comment on lines
+192
to
+195
| type MetricsBuilderConfig struct { | ||
| Metrics MetricsConfig `river:"metrics,block,optional"` | ||
| ResourceAttributes ResourceAttributesConfig `river:"resource_attributes,block,optional"` | ||
| } |
There was a problem hiding this comment.
In the follow-up PR we also need to document these options in our docs.
Merged
4 tasks
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR adds
otelcol.receiver.vcenterwhich enables collection of metrics of vSheremachines.
PR Checklist